refactor script to account for multiple gallery carousels on front end #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snovosel
requested review from
jrtashjian,
EvanHerman,
AnthonyLedesma,
jonathanbardo and
olafleur-godaddy
as code owners
|
Download coblocks.zip: https://47073-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2278.zip |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
olafleur-godaddy
approved these changes
Feb 22, 2022
olafleur-godaddy
previously requested changes
Feb 23, 2022
There was a problem hiding this comment.
There seems to still be problems with the lightboxs, according to a user : https://wordpress.org/support/topic/multiple-carousels-in-the-same-article-do-not-work/#post-15394542
olafleur-godaddy
dismissed
their stale review
Unable to reproduce lightbox problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the front end script for the GalleryCarousel block to account for multiple carousels within the same page
Screenshots
Types of changes
Bug Fix
How has this been tested?
Tested on front end with multiple carousels present
Checklist: