try using translation function with registerBlockType #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
requested review from
jrtashjian,
EvanHerman,
jonathanbardo and
olafleur-godaddy
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
olafleur-godaddy
approved these changes
Mar 18, 2022
|
Ok, let's try that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am pretty sure this will fix the issue with the blocks list on WordPress.org. I based the fix based on the plugin details page for another popular plugin. I was not able to find any docs elsewhere to explain the requirements. Based on the aforementioned plugin details we know that three of the blocks are setup to display as expected.
What the three blocks have in common are strings processed by the translation function.
All other blocks of this plugin are setup to use strings that are not translated.
Alternatives considered
We are not able to use the
__function in the same manner and must instead use a combination withsprintfand a suffix ofblockin order to satisfy all lint conditions around the translation function. If this proposed solution does not work that implies that we must register the block using only string literals and not variables.Acceptance criteria
We will need to test this which I think may require a release. We need to update the JS side.
Checklist: