Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all blocks to leverage animations #2335

Merged
merged 2 commits into from
May 17, 2022
Merged

Allow all blocks to leverage animations #2335

merged 2 commits into from
May 17, 2022

Conversation

EvanHerman
Copy link
Contributor

Description

Allow all blocks (including core) to leverage CoBlocks animations.

Types of changes

New feature (non-breaking change which adds functionality)

How has this been tested?

Manually tested adding animations to a number of CoBlocks. Checked in the editor and on the front of site.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Mar 23, 2022
@EvanHerman EvanHerman self-assigned this Mar 23, 2022
@godaddy-wordpress-bot
Copy link
Contributor

godaddy-wordpress-bot commented Mar 23, 2022 •
edited
Loading

Download coblocks.zip: https://output.circle-artifacts.com/output/job/09ff7d97-3a30-440a-ad5e-ebf5c3e960ed/artifacts/0/tmp/artifacts/coblocks-2335.zip

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.65% 💚

🗂 Folder Coverage 
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    95.83% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     80.10% 💚
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                         100.00% ✅
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 48860

@cypress
Copy link

cypress bot commented Mar 23, 2022 •
edited
Loading


Test summary

392 • 2 • 2 • 0

Run details
Project CoBlocks
Status Failed
Commit ec9c137
Started May 11, 2022 4:22 PM
Ended May 11, 2022 4:26 PM
Duration 04:38 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

Run group: e2e-chrome-wp-latest (Linux, Chrome )
src/blocks/hero/test/hero.cypress.js 1 Failed
1 Test CoBlocks Hero Block > should close media upload flow on media selection
Run group: e2e-firefox-wp-latest (Linux, Firefox )
src/blocks/hero/test/hero.cypress.js 1 Failed
1 Test CoBlocks Hero Block > should close media upload flow on media selection

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

godaddy-wordpress-bot commented Mar 23, 2022 •
edited
Loading

Performance Test Results:

index master animate-all-blocks change %
focus 103.97 145.11 39.57%
inserterHover 35.14 36.47 3.78%
inserterOpen 114.46 110.86 -3.15%
inserterSearch 78.8 78.94 0.18%
load 20827.3 22779.2 9.37%
maxFocus 140.06 301.01 114.92%
maxInserterHover 50.28 41.99 -16.49%
maxInserterOpen 452.96 440.86 -2.67%
maxInserterSearch 167.81 171.94 2.46%
maxType 69.19 110.19 59.26%
minFocus 91.62 110.06 20.13%
minInserterHover 30.96 33.38 7.82%
minInserterOpen 69.02 70.35 1.93%
minInserterSearch 51.48 51.21 -0.52%
minType 36.44 41.03 12.6%
type 46.11 52.25 13.32%

@EvanHerman EvanHerman added [Status] Do Not Merge Issues/PRs that should not be merged (yet) [Status] Needs Review Tracking pull requests that need another set of eyes labels Mar 24, 2022
@AnthonyLedesma
Copy link
Member

Just a note here for when we return to this PR. There is a bug with the Animation extension extraFeature. This extra feature acts to hide the toolbar during animation. The bug is documented in a comment here:
#2334 (comment)

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.52% 💚

🗂 Folder Coverage 
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    95.83% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     80.10% 💚
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                          96.43% 💚
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 53485

jrtashjian
jrtashjian approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@jrtashjian jrtashjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@jrtashjian jrtashjian merged commit 9bd73fb into master May 17, 2022
@jrtashjian jrtashjian deleted the animate-all-blocks branch May 17, 2022 15:33
@olafleur-godaddy olafleur-godaddy mentioned this pull request May 17, 2022
Merged
@adamf59 adamf59 added this to the Next Release milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrtashjian jrtashjian jrtashjian approved these changes

@AnthonyLedesma AnthonyLedesma Awaiting requested review from AnthonyLedesma

@jonathanbardo jonathanbardo Awaiting requested review from jonathanbardo

@olafleur-godaddy olafleur-godaddy Awaiting requested review from olafleur-godaddy

Assignees

@EvanHerman EvanHerman

Labels
[Status] Do Not Merge Issues/PRs that should not be merged (yet) [Status] Needs Review Tracking pull requests that need another set of eyes [Type] Enhancement Something new that adds functionality
Projects
None yet
Milestone
2.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EvanHerman @godaddy-wordpress-bot @AnthonyLedesma @jrtashjian @adamf59