WPEX-1922 - disable links in editor, enable gist links in front end #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snovosel-godaddy
requested review from
jrtashjian,
EvanHerman,
AnthonyLedesma,
jonathanbardo and
olafleur-godaddy
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
snovosel-godaddy
removed request for
jrtashjian,
jonathanbardo,
AnthonyLedesma and
olafleur-godaddy
|
@snovosel-godaddy we'll need to fix the unit tests as well |
EvanHerman
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the Gist block which (within the editor) any links within the Gist iframe will open within the iframe itself rather than the window. These changes disable the links within the editor and include a script on the front end to re-enable the links.
Fixes #2326
Screenshots
Types of changes
Bug fix
How has this been tested?
manually
Acceptance criteria
Links should not be clickable/openable within the editor.
Checklist: