-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cypress tests for certain blocks in WP 6.0 #2376
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed up a change to move back to a single helper function. LGTM.
Unfortunately, after having tried this refactoring commit on an RC2 branch, it broke other block tests : https://app.circleci.com/pipelines/github/godaddy-wordpress/coblocks/9405/workflows/318bf1fd-8d9c-4e99-8aca-fd18a51997f2/jobs/53570/parallel-runs/5?filterBy=FAILED It broke the FAQ, Features and Form block, at least. I will revert it for the moment. |
This reverts commit b572b70.
Description
Fix Cypress tests for these blocks / plugins in WP 6.0 :