Check for WP_Error in wp_remote_get; fixes #2386 #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefrosty
requested review from
jrtashjian,
EvanHerman,
AnthonyLedesma,
jonathanbardo and
olafleur-godaddy
as code owners
olafleur-godaddy
previously requested changes
May 26, 2022
There was a problem hiding this comment.
The pipeline does not seem to run our your PR (maybe a config issue), but I can see that the PHP tests and linting are failing (ex : https://app.circleci.com/pipelines/github/godaddy-wordpress/coblocks/9503/workflows/1e53351b-47d1-4a51-812f-4e7d3f87773f )
Please make sure that the yarn lint:php and yarn test:php commands are not failing.
Thank you!
olafleur-godaddy
removed request for
jrtashjian,
jonathanbardo,
EvanHerman and
AnthonyLedesma
thefrosty
commented
May 31, 2022
AnthonyLedesma
approved these changes
Jun 8, 2022
|
Yes, thanks for your contribution! |
|
I just added you in the contributors list : https://github.com/godaddy-wordpress/coblocks/blob/master/CONTRIBUTORS.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2386
Screenshots
Types of changes
How has this been tested?
Acceptance criteria
Checklist: