🎉🚀👻 OH YEAH ... it's web time! #4
Conversation
[fix] Re-enable EX_CROSS_PLATFORM in load-examples.js [tiny ux] Use example index as a prefix in story name. [fix api] Implement preset-based solution based on storybookjs/storybook#4995 [api] Debug using `diagnostics` [refactor] Move reusable functionality from package/react/webpack.config.js to packages/react/{constants,resolve}.js
packages/react/package.json
Outdated
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "self": "node bin/start.js" | ||
| "lint": "eslint-godaddy-react bin/*.js examples/*.js *.js ./.storybook/*.js --no-ignore", | ||
| "test": "nyc mocha test/*.test.js", |
There was a problem hiding this comment.
These test files do not exist.
There was a problem hiding this comment.
"You're not thinking fourth dimensionally
MartySivan! Thebridgetest files WILL EXISTin 1985when that check box is checked!"
- Doc
BrownRobbins
| "storybook": "start-storybook -c ./" | ||
| }, | ||
| "bin": { | ||
| "start-exemplar": "bin/start-exemplar.js" |
There was a problem hiding this comment.
This file currently hard codes port 6006, do we want to maintain that or allow the -p flag the storybook typically expects?
There was a problem hiding this comment.
IMHO it should providing a sane default, but allow overriding
| @@ -4,8 +4,14 @@ | |||
| "description": "Storybook rocket fuel to launch structured examples of React", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "self": "node bin/start.js" | |||
| "lint": "eslint-godaddy-react bin/*.js examples/*.js *.js ./.storybook/*.js --no-ignore", | |||
There was a problem hiding this comment.
you could do that like so for (maybe) improved readability / future-proofing
"lint": "eslint-godaddy-react \"{bin,examples,.storybook}/**/*.js\" *.js --no-ignore",
similarly with the test script:
"test": "nyc mocha \"test/**/*.test.js\"",
| "storybook": "start-storybook -c ./" | ||
| }, | ||
| "bin": { | ||
| "start-exemplar": "bin/start-exemplar.js" |
There was a problem hiding this comment.
IMHO it should providing a sane default, but allow overriding
indexzero
dismissed
SivanMehta’s stale review
Requested changes have been made.
| }); | ||
|
|
||
| it('build-storybook -c ./ should work correctly', assumeBuildStorybook('./')); | ||
| it('build-storybook -c ./.storybook should work correctly', assumeBuildStorybook('./.storybook')); |
There was a problem hiding this comment.
This isn't very comprehensive but it's a good starting point.
Notable Changes
package/react/webpack.config.jstopackages/react/{constants,resolve}.jsREADME.mdSmall additional changes
diagnostics