Switch execution to x/sys/execabs for windows security fix #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may or may not be relevant. I don't know how much it makes sense (or is possible) to use dbus on Windows, but I wanted to be nice and open this as part of the efforts in fyne-io/fyne#2344. The os/exec package on Windows will match the behaviour of cmd.exe by considering the local folder as a primary part of the path. This means that a malicious binary with the same name, in the current folder, would be run instead of the expected binary in the system path. Due to the backwards compat being an issue, this could not be fixed within ox/exec before Go v2. See https://blog.golang.org/path-security for more info.
|
This appears to cause a problem with the "TestDbusLaunchMultilineResponse" test. |
|
I'm generally OK with the change as long as the test breakage is addressed. |
|
I'm honestly not entirely sure why the test fails. Will have to look into it more. |
|
Sorry. I have a little too much on my plate at the moment. Feel free to take this over if anyone is interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may or may not be relevant. Feel free to close this PR if you don't think that it is useful. I don't know how much it makes sense (or is possible) to use dbus on Windows, but I wanted to be nice and open this as part of the efforts in fyne-io/fyne#2344. We do not use use this library on Windows in our use cases.
Summary of the reasoning behind this change:
The os/exec package on Windows will match the behaviour of cmd.exe by considering the local folder as a primary part of the path. This means that a malicious binary with the same name, in the current folder, would be run instead of the expected binary in the system path. Due to the backwards compat being an issue, this could not be fixed within ox/exec before Go v2. See https://blog.golang.org/path-security for more info.