Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive godot_print-ing for classes loading and unloading #448

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

kkolyan
Copy link
Contributor

@kkolyan kkolyan commented Oct 13, 2023

There are complaints about the godot_prints that I added recently. That make sense, so let's make them outs instead.

@kkolyan kkolyan mentioned this pull request Oct 13, 2023
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-448

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: register Register classes, functions and other symbols to GDScript labels Oct 13, 2023
@Bromeon
Copy link
Member

Bromeon commented Oct 13, 2023

Makes sense, thanks! Unfortunately I can't merge until we address the CI issues, but I'm working on them.

@Bromeon Bromeon added this pull request to the merge queue Oct 13, 2023
Merged via the queue into godot-rust:master with commit 5aade3a Oct 13, 2023
14 checks passed
@Bromeon
Copy link
Member

Bromeon commented Oct 13, 2023

Found a workaround for the memcheck CI, and the macOS one has 80-90% chance of succeeding, so merging worked! 😅

Thanks!

@kkolyan kkolyan deleted the 434_hot_reload branch October 17, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: register Register classes, functions and other symbols to GDScript quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants