Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out Callable functions #979

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Flesh out Callable functions #979

merged 3 commits into from
Dec 22, 2024

Conversation

lilizoey
Copy link
Member

No description provided.

@lilizoey lilizoey added feature Adds functionality to the library c: core Core components labels Dec 17, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-979

@lilizoey lilizoey force-pushed the feature/callable-hackathon branch from f06a055 to 3abf4c6 Compare December 17, 2024 21:14
@lilizoey lilizoey force-pushed the feature/callable-hackathon branch from 3abf4c6 to 209e01a Compare December 17, 2024 21:20
@Bromeon Bromeon added the c: engine Godot classes (nodes, resources, ...) label Dec 18, 2024
Bromeon
Bromeon approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

The _len functions might be clearer as _count, but I'll anyway plan some work on callables, so can change it as part of that.

@Bromeon Bromeon marked this pull request as ready for review December 22, 2024 21:38
@Bromeon Bromeon added this pull request to the merge queue Dec 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2024
@Bromeon Bromeon enabled auto-merge December 22, 2024 22:41
@Bromeon Bromeon force-pushed the feature/callable-hackathon branch from 40a70fe to 275756e Compare December 22, 2024 22:43
@Bromeon Bromeon added this pull request to the merge queue Dec 22, 2024
Merged via the queue into godot-rust:master with commit fe5a6b2 Dec 22, 2024
15 checks passed
@Bromeon Bromeon mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

Assignees
No one assigned
Labels
c: core Core components c: engine Godot classes (nodes, resources, ...) feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilizoey @GodotRust @Bromeon