We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set
VariantArray
As mentioned in discord
let vertices : Vec<Vector3> = vec![]; let arrays = VariantArray::new(); arrays.set(ArrayMesh::ARRAY_VERTEX as i32, vertices);
The issue is that VariantArray::set is not an unsafe function.
VariantArray::set
This should be corrected either by making the function unsafe, or doing some internal bounds checking to be inline with the Rust guidelines.
As a follow-up we should review the VariantArray/Dictionary APIs to ensure there's no other unexpected UB
Dictionary
The text was updated successfully, but these errors were encountered:
Merge #795
ac9d40e
795: Remove or change APIs causing UB r=Bromeon a=Bromeon Fixes #790 Changes in commit message Co-authored-by: Jan Haller <[email protected]>
8c5cda8
Successfully merging a pull request may close this issue.
As mentioned in discord
The issue is that
VariantArray::set
is not an unsafe function.This should be corrected either by making the function unsafe, or doing some internal bounds checking to be inline with the Rust guidelines.
As a follow-up we should review the
VariantArray
/Dictionary
APIs to ensure there's no other unexpected UBThe text was updated successfully, but these errors were encountered: