Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[357] Sealing access::{Guard, WritePtr} #477

Merged
merged 1 commit into from
Jun 27, 2020
Merged

[357] Sealing access::{Guard, WritePtr} #477

merged 1 commit into from
Jun 27, 2020

Conversation

halzy
Copy link
Member

@halzy halzy commented Jun 26, 2020 •
edited by karroffel
Loading

Resolves part of #357
Traits that are #[doc(hidden)] but should be public and sealed

@ghost
Copy link

ghost commented Jun 26, 2020

I don't think these are proper sealed traits. The purpose of putting a Sealed trait in a private module is so that downstream crates won't be able to name the Sealed trait and implement it. With blanket implementations it would still be possible to implement the outer trait, if I'm not mistaken.

@halzy halzy force-pushed the halzy/trait-seal branch 2 times, most recently from c774739 to febab61 Compare June 26, 2020 18:53
@halzy
Copy link
Member Author

halzy commented Jun 26, 2020

You are correct, I was using the wrong pattern here. Updated the tests and the traits.

@halzy halzy force-pushed the halzy/trait-seal branch 2 times, most recently from 3ca45b9 to a2c6e1f Compare June 26, 2020 21:32
@karroffel
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 26, 2020
@bors
Try #477:
568d2cc
@bors
Copy link
Contributor

bors bot commented Jun 26, 2020

try

Build succeeded:

@halzy halzy force-pushed the halzy/trait-seal branch from a2c6e1f to 3ad8314 Compare June 27, 2020 02:52
ghost
ghost approved these changes Jun 27, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 27, 2020

Build succeeded:

@bors bors bot merged commit b56b908 into godot-rust:master Jun 27, 2020
@ghost ghost mentioned this pull request Jun 27, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halzy @karroffel