[357] Removing sys from godot_gdnative_init() args.

[halzy]

godot_gdnative_init() callbacks can now report loading errors via InitCallbackInfo:: report_loading_error()

[ghost]

I hate to say it, but this missed the point. The purpose of high-level init option wrappers is not to expose the low-level API structs to users: that's the job of gdnative-sys! Instead, it's for exposing information that could be useful to users, without exposing sys types, so that gdnative-sys can be considered an internal dependency and have different version numbers from the main crate. This is actually the entire underlying theme of #357, as said at the beginning of that issue. See #291 for the rationale of this.

Here, the only things that I think should be exposed to users in InitCallbackOptions are in_editor, active_library_path, and report_loading_error. The other fields are low-level details that users should not care about.

[halzy]

I'm glad! This is the sort of feedback I was looking for. That API did seem to reveal too much and why I stopped before unwrapping more. It seems we could use the version mismatch fn() when we bail on Godot 4.

[ghost]

I think bailing on Godot 4 is better done in gdnative-sys, because the (incorrect) API struct would already have been constructed (in bind_api) by the time the callback is called, and we don't want that to happen.

[ghost]

Looks good to me!

bors r+

[bors]

Build succeeded:

• continuous-integration/travis-ci/push