-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sphinx and requirements #10158
Conversation
29df6d2
to
3b58268
Compare
3b58268
to
6a9dc9b
Compare
I've been testing this these past few days and had no issues, so I think we can go ahead with this, considering the current trouble with the outdated build we currently use. Both the web/HTML build and the EPUB one seem to work.
The discussion on the Sphinx 8.1 release at first made me think this was just an error on the Sphinx side (see this issue: sphinx-doc/sphinx#13012). And to quote:
However, it felt a bit odd that this only happens to a very limited set of files in the class reference: Editor-only classes, and Node/Resource/Object. It seems they are the classes that are listed more than once in the class reference index ( For example, I guess for social cards, you mean these warnings?
|
Yes, I haven't checked if this is still an issue. I added it at the time and never removed it as we probably don't want them anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely is still an issue. Not sure if wanted or not, I think social cards were at least nice once upon a time for Twitter, but with how that whole thing is going, well. Alright, not that much of a priority anyway, let's go ahead and merge this and see how it pans out for everyone on master
/latest
at least. Thanks for your work :)
Cherrypicked to 4.3 in #10346. |
supersede #7443
Update CI OS version for sphinx 8.x support (I guess phyton version?)
disable social cards, because of warnings
remove
html_theme_path
anddisplay_version
as this are outdated optionsremove search css, as this shouldn't be required anymore
remove cache busters, as this is now integrated
remove pinned dependencies
update dependencies
class_scripteditor.rst: document is referenced in multiple toctrees: ['classes/index', 'classes/index'], selecting: classes/index <- classes/class_scripteditor
is an information and can't be suppressed, like a warning. (as far as I know)