Added warning for Area2D GetOverlappingAreas() method #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make note that default atlas setting only allows 16 probes
Although line 6 is safe, line 7, that actually is what the paragraph talking about, is unsafe and line 8 is safe. The way it was before, it was in reverse order, making it confusing which is safe and which is not. So I changed the order to be as the picture. To further assure it is clear, I added the line numbers in parentheses. The parentheses could be excessive verbosity, but the order importance stands. I believe it was confusing before. Alternatively, the picture could be changed, having the safe line first. Then it's clearer as the unsafe line it's the only one different and the order would be also correct; 2 safe lines, one unsafe for last. Specifying the lines would not be needed then.
Co-authored-by: Hugo Locurcio <[email protected]> (cherry picked from commit ff2b3e4)
And improve TIME.
Document upcoming CI shader builtin MODULATE
This is based on feedback from godotengine/godot-build-scripts#6 (comment)
[3.2] Update the naming scheme for the Godot Android library
Nope, too big and seen as invalid by most readers. See #3862. There's really no good option for offline downloads currently.
Document that 2D batching currently only works with the GLES2 renderer
Proofread and improve the optimization guides
Includes `class_name` in the keywords list, and updates the definition of `class`.
…pt-basics Update Keywords to include class_name
Mention limit of 8 lights per mesh
Note: This merge is a no-op, it adds #4074 but removes all its changes, as we don't want to remove content from 3.2 docs. This merge enables us to further use `git merge master` to get `master` changes into `3.2` without worrying about those removals, as they have been handled in this commit.
I added aditional information on how get_overlapping_areas function as of right now.
LordBrkica
changed the title
|
Thanks for opening a pull request! Contributions to the class reference should be sent on the main Godot repository, not here. This is because the class reference in this repository is generated automatically based on the XML files in the main repository. See Contribute to the class reference in the documentation 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added aditional information on how get_overlapping_areas functions as of right now. The bug is there since January 2017 so a proper information should be present in the method description as well.