Add newly shader built-ins to docs backport #6152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-exe
force-pushed
the
backport-shader-built-ins
branch
from
f7448cc to
e2daac4
Compare
clayjohn
reviewed
Sep 7, 2022
paddy-exe
force-pushed
the
backport-shader-built-ins
branch
from
e2daac4 to
8e4139f
Compare
|
Thanks for your feedback @clayjohn! I updated it to your feedback |
clayjohn
approved these changes
Sep 7, 2022
|
Great work! |
mhilbrunner
approved these changes
Sep 8, 2022
mhilbrunner
reviewed
Sep 8, 2022
Comment on lines
179
to
180
| || in bool **OUTPUT_IS_SRGB** || ``true`` when calculations happen in sRGB color space | | ||
| || || (``true`` in GLES2, ``false`` in GLES3). | |
There was a problem hiding this comment.
I can always count on you :D thanks for noticing
paddy-exe
force-pushed
the
backport-shader-built-ins
branch
from
8e4139f to
2b7c491
Compare
mhilbrunner
approved these changes
Sep 8, 2022
|
Thank you! |
|
So, uhm, this is for 3.6, not 3.5... |
|
Started the 3.6 branch with this PR merged, and reverted it in the 3.5 branch. Let me know if I everything is good. 🙂 |
|
@YuriSizov Seems good to me! Sorry, should have specified the PR for 3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6022
Docs of godotengine/godot#63971