Fix some $ node path shorthand regex bugs in syntax highlighting
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex now supports: - Unquoted node paths with numbers eg. $Node2D/Area2D - Single-quoted node paths eg. $'Node/Sprite' - Quoted node paths with spaces eg. $"Node/Main Menu"
|
Out of curiosity, how did you generate the regex diagrams? These look great 🙂 |
Calinou
approved these changes
Apr 5, 2022
Calinou
changed the title
$ node path shorthand regex bugs in syntax highlighting
I used https://extendsclass.com/regex-tester.html#ruby which is mentioned in the README in this folder so it was new to me too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex now supports:
$Node2D/Area2D$'Node/Sprite'$"Node/Main Menu"Old regex syntax diagram:
New regex syntax diagram:
