Add highlighting support for %Unique nodes in NodePaths #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new Scene Unique Node syntax in NodePaths.
The highlighting works in
$"Shorthand"and in string arguments to common NodePath-using functions.I added a bonus feature that highlights invalid Unique nodes inside bare shorthands as red, eg:
$%Uniqueor$Child/%Unique, because as far as I could tell, that's not supported syntax. In my opinion, this is not the job of the syntax highlighter, but a quick test shows me that the error displayed from the LSP is not exactly helpful if you don't already understand the feature:My hope is that the highlighting will help the adoption of %Unique nodes, and I can come back later and either remove this highlighting or re-implement it in a more appropriate place.