Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API compatibility broken for KinematicBody and KinematicBody2D #19648

Closed
vnen opened this issue Jun 19, 2018 · 1 comment
Closed

API compatibility broken for KinematicBody and KinematicBody2D #19648

vnen opened this issue Jun 19, 2018 · 1 comment
Assignees
@AndreaCatania
Labels
bug topic:physics
Milestone
3.1

Comments

@vnen
Copy link
Member

vnen commented Jun 19, 2018

Godot version:
ff01fd5

OS/device including version:
Any

Issue description:
Some methods of KinematicBody and KinematicBody2D got a new argument in #16757, so existing code would have to change in order to adhere to the new order. It might be the case for the physics servers as well.

The solution is changing the new argument to be the last one.
@vnen vnen added this to the 3.1 milestone Jun 19, 2018
@vnen vnen mentioned this issue Jun 19, 2018
Closed
83 tasks
AndreaCatania added a commit to AndreaCatania/godot that referenced this issue Jul 1, 2018
@AndreaCatania
Fixes godotengine#19648 Kinematic body move_and_slide compatibility i…
16cf262 
…ssue
@akien-mga
Copy link
Member

Fixed by #19884.

akien-mga added a commit that referenced this issue Jul 1, 2018
@akien-mga
Merge pull request #19884 from AndreaCatania/compfix
c9b57d4 
Fixes #19648 Kinematic body move_and_slide compatibility issue
malcolmhoward pushed a commit to malcolmhoward/godot that referenced this issue Jul 31, 2018
@AndreaCatania @malcolmhoward
Fixes godotengine#19648 Kinematic body move_and_slide compatibility i…
7aa8d39 
…ssue
malcolmhoward pushed a commit to malcolmhoward/godot that referenced this issue Jul 31, 2018
@AndreaCatania @malcolmhoward
Fixes godotengine#19648 Kinematic body move_and_slide compatibility i…
6329590 
…ssue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreaCatania AndreaCatania

Labels
bug topic:physics
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
3 participants
@akien-mga @vnen @AndreaCatania