Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New input map editor no longer displays icons for inputs and device text #53708

Closed
Calinou opened this issue Oct 12, 2021 · 3 comments · Fixed by #53734 or #59514
Closed

New input map editor no longer displays icons for inputs and device text #53708

Calinou opened this issue Oct 12, 2021 · 3 comments · Fixed by #53734 or #59514

Comments

@Calinou
Copy link
Member

Calinou commented Oct 12, 2021

Godot version

4.0.dev (94ce83b)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 470.57.02)

Issue description

This is how input actions currently display in master:

image

In contrast, this is how the same configuration looks like in 3.x:

image

It's more informative (as it displays the device IDs for mouse buttons and joypad buttons) and easier to visually grep thanks to the icons.

Steps to reproduce

  • Create input actions in the input map editor.
  • Look at the presentation of those input actions in the editor.

Minimal reproduction project

master: 4.zip
3.x (not compatible with 3.3.4): 3.zip

@Calinou
Copy link
Member Author

Calinou commented Oct 12, 2021

After further testing, it seems that the device isn't stored properly in master. No matter the value I choose in the dropdown, the device stored in project.godot is always 0.

I noticed this while working on a PR to use "All Devices" as a default option, since it works more reliably for singleplayer games and touchscreen input.

@EricEzaM
Copy link
Contributor

Still open - multi-part issue. FYI @Calinou I am working on the 2nd part and should have a PR shortly.

@EricEzaM
Copy link
Contributor

After further testing, it seems that the device isn't stored properly in master. No matter the value I choose in the dropdown, the device stored in project.godot is always 0.

I noticed this while working on a PR to use "All Devices" as a default option, since it works more reliably for singleplayer games and touchscreen input.

Looks like I never connected up the device dropdown to actually do anything... oops! Should be all good with my PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants