Action Map Editor fixes and improvements #59514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricEzaM
force-pushed
the
input-editor-fixes
branch
2 times, most recently
from
25906a2 to
3594fd7
Compare
EricEzaM
force-pushed
the
input-editor-fixes
branch
2 times, most recently
from
40d1ad2 to
d87cb25
Compare
Multiple fixes: * Fixed device not being updated correctly (changing the device dropdown did not actually change the underlying event's device) * Device selection now defaults to `All Devices` * Device is now displayed in the text shown in the input event editor, and in the action list. * There was code running twice previously because of the following interaction: 1) input via "Listen for Input" tab. 2) `_set_event` gets called. 3) input list tree selection gets updated to match the listened event. 4) tree "item_selection" signal is emitted. 5) eventually `_set_event` is called again. * The only reason this was not an infinite loop is because reselection is disabled on the tree. So, the code runs twice - not a big deal, but it is unnecessary processing and it could cause an issue in the future. If someone turns on reselection on the tree, the whole thing comes crashing down. This should prevent that scenario and make the code a bit safer and more robust.
EricEzaM
force-pushed
the
input-editor-fixes
branch
from
d87cb25 to
cc6a181
Compare
akien-mga
approved these changes
Apr 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes:
All Devices_set_eventgets called. 3) input list tree selection gets updated to match the listened event. 4) tree "item_selection" signal is emitted. 5) eventually_set_eventis called again.Closes #53708 (what was left after #53734 was merged)
Closes #26880 as per @Calinou's suggestion #26880 (comment)
Closes #60065