Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_from_group: Condition "!data.grouped.has(p_identifier)" is true #69916

Open
rafaelcastrocouto opened this issue Dec 11, 2022 · 1 comment

Comments

@rafaelcastrocouto
Copy link

rafaelcastrocouto commented Dec 11, 2022

Godot version

3.5.1.stable

System information

Win 10

Issue description

I'm taking a screenshot capture of the map to use as background for the minimap.
The whole code to get the correct image following this viewports doc:

var data = get_tree().get_current_scene().get_viewport().get_texture().get_data().flip_y()
var texture = ImageTexture.new()
texture.create_from_image(data, 1)

Accessing the viewport is now giving me this remove_from_group error that I didn't had before. The main thing that changed is that I created more maps and had to move the map node to an external scene. The capture still works as intended and this error is not hurting the development in any way, I just thought I should warn since we do not have any kind of remove_from_group calls on our scripts as the error message suggests.

Steps to reproduce

I'm still not sure how to reproduce since a lot changed in our code because of the amount of recent contributions ... I had a hard time figuring out where the error was comming from, since the error message is totally missleading.
I will certainlly investigate it further and try to create a consise example but all help is welcome.

Minimal reproduction project

not yet (non minimal: https://github.com/spicylobstergames/shotcaller-godot)

#45332 also mentions the same error, but I'm guessing these are not the same issues

@rafaelcastrocouto
Copy link
Author

rafaelcastrocouto commented Feb 18, 2023

Seems like this happens when you use .queue_free() and take a screenshot capture on the same frame.

Adding yield(get_tree(), "idle_frame") after clearing the queue and before capturing the screenshot clears the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants