Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of nodes with custom icon gets truncated too early #83801

Closed
peterhoglund opened this issue Oct 22, 2023 · 6 comments · Fixed by #84001
Closed

Names of nodes with custom icon gets truncated too early #83801

peterhoglund opened this issue Oct 22, 2023 · 6 comments · Fixed by #84001

Comments

@peterhoglund
Copy link

Godot version

4.2 beta 1

System information

MacOS 11.7.4

Issue description

When using a custom icon on a node (of type Node in this case) by using @icon("path/") the name in the Scene tree gets truncated too early, leaving a few hundred pixels empty on the right side before the icons.

If I remove the icon the name is no longer truncated like this.

image

Steps to reproduce

Create a Node node. In code assign a custom icon. Reduce the width of the scene tree dock in the editor.

Minimal reproduction project

@chybby
Copy link
Contributor

chybby commented Oct 26, 2023

I was looking into this today, looks like the text is being truncated based on the size of the icon's texture, not the size of the icon. Should be able to get a fix working today.

@peterhoglund
Copy link
Author

@chybby Great! I also noticed that the custom icon in the Signals list is the true image size and not scaled down to fit the category title height. Might be related?

@chybby
Copy link
Contributor

chybby commented Oct 26, 2023

@chybby Great! I also noticed that the custom icon in the Signals list is the true image size and not scaled down to fit the category title height. Might be related?

I don't think that's directly related. Do you mean here?

godot windows editor dev x86_64_cFDyjfJakT

Because it looks like it's working for me.

I did find some other places that uses the full image size however:

Recently edited objects history:

godot windows editor dev x86_64_4YADIV8U03

In the Search Help dialog:

godot windows editor dev x86_64_rgFNOkijyN

@peterhoglund
Copy link
Author

I don't think that's directly related. Do you mean here?

Yes, this is what it looks like to me. I'm on 4.2 beta 1.
image

@chybby
Copy link
Contributor

chybby commented Oct 26, 2023

Ah, that was fixed by #83447

@YuriSizov YuriSizov added this to the 4.2 milestone Oct 26, 2023
@peterhoglund
Copy link
Author

Super, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants