AudioStreamInteractive transition fade_beats is an integer while being handled as float everywhere

[timoschwarzer]

Tested versions

• 4.4.dev [277cb68]

System information

Godot v4.4.dev (277cb68) - Arch Linux #1 ZEN SMP PREEMPT_DYNAMIC Fri, 01 Nov 2024 03:30:35 +0000 on Wayland - X11 display driver, Multi-window, 2 monitors - Vulkan (Forward+) - dedicated Intel(R) Arc(tm) A770 Graphics (DG2) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 threads)

Issue description

• fade_beats is stored as int internally here
• In add_transition and the editor plugin it's handled as float.
• The GUI input in the editor plugin also allows entering decimal values, which get silently dropped.

Steps to reproduce

• Create an AudioStreamInteractive and try to add a transition with e.g. 1.5 beats of transition time. The 1.5 get truncated to 1. You notice when reopening the transition dialog.

Minimal reproduction project (MRP)

N/A

[PhairZ]

should we assume that fade_beats can only take whole beats?

[timoschwarzer]

From what I can see here that is not the case. Float values should work just fine. (transition.fade_beats there is the int currently)

[PhairZ]

Well, I checked it and fixing it is as easy as changing the fade_beats in here to float

[timoschwarzer]

@PhairZ do you want to open a PR or should I do it?

[PhairZ]

I'd be happy to open it. @timoschwarzer