Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fade_beats defined as int in audio_stream_interactive.h #99186

Merged

Conversation

PhairZ
Copy link
Contributor

@PhairZ PhairZ commented Nov 13, 2024

@PhairZ PhairZ changed the title fix fade_beats defined as int in audio_stream_interactive.h fix fade_beats defined as int in [audio_stream_interactive.h](https://github.com/godotengine/godot/blob/master/modules/interactive_music/audio_stream_interactive.h#L103) Nov 13, 2024
@PhairZ PhairZ changed the title fix fade_beats defined as int in [audio_stream_interactive.h](https://github.com/godotengine/godot/blob/master/modules/interactive_music/audio_stream_interactive.h#L103) fix fade_beats defined as int in audio_stream_interactive.h Nov 13, 2024
@PhairZ PhairZ marked this pull request as ready for review November 13, 2024 17:57
@PhairZ PhairZ requested a review from a team as a code owner November 13, 2024 17:57
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 13, 2024
@fire fire changed the title fix fade_beats defined as int in audio_stream_interactive.h Fix fade_beats defined as int in audio_stream_interactive.h Nov 14, 2024
@adamscott adamscott changed the title Fix fade_beats defined as int in audio_stream_interactive.h Fix fade_beats defined as int in audio_stream_interactive.h Dec 5, 2024
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@Repiteo Repiteo merged commit 7bff6c8 into godotengine:master Dec 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioStreamInteractive transition fade_beats is an integer while being handled as float everywhere
4 participants