Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make backward be parameter of the AnimationTree in the AnimationNodeAnimation #100039

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Make backward be parameter of the AnimationTree in the AnimationNodeAnimation #100039

merged 1 commit into from
Dec 17, 2024

Conversation

TokageItLab
Copy link
Member

Properties that need to be managed for each AnimationTree should be parameterized for the same reason as #22887.

@TokageItLab TokageItLab added bug topic:animation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Dec 5, 2024
@TokageItLab TokageItLab added this to the 4.4 milestone Dec 5, 2024
@TokageItLab TokageItLab requested a review from a team as a code owner December 5, 2024 11:49
@mrjustaguy
Copy link
Contributor

I can confirm this Fixes the broken Ping Pong looping

@akien-mga akien-mga merged commit f1eb2f9 into godotengine:master Dec 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Spartan322 Spartan322 mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:animation
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
5 participants
@TokageItLab @mrjustaguy @akien-mga @fire @AThousandShips