Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow canceling drag-and-drop with right mouse button #100259

Merged

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Dec 10, 2024

This is a small usability enhancement, that allows users to cancel drag-and-drop without the need to press the escape key on the keyboard by just utilizing the mouse.

implements and closes discussion godotengine/godot-proposals#11048
continuation of #68418

I have seen this ability in other gui-tool-kits and it seems to me like a nice quality of life feature.

This is a small usability enhancement, that allows users to cancel
drag-and-drop without the need to press the escape key on the keyboard.
@Sauermann Sauermann force-pushed the proposal-right-click-cancel-drag branch from 6a4dccc to 4d6a6b2 Compare December 10, 2024 23:15
@Sauermann Sauermann requested a review from a team as a code owner December 10, 2024 23:15
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected (editor and https://github.com/godotengine/godot-demo-projects/tree/master/gui/drag_and_drop).

Code looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 11, 2024
@Repiteo Repiteo merged commit 2b41a21 into godotengine:master Dec 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 11, 2024

Thanks!

@Sauermann Sauermann deleted the proposal-right-click-cancel-drag branch December 11, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants