Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renderer motion vectors API for use with OpenXR #100282

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

devloglogan
Copy link
Contributor

@devloglogan devloglogan commented Dec 11, 2024

This is the renderer-agnostic portion of #97151. That PR will remain for the compatibility renderer implementation portion. This PR lays the framework for OpenXR to provide motion vector related render targets to the renderer, allowing for the use of application space warp.

If you're interested in testing it out, you'll have to build using either the compatibility (#97151) or mobile (#100283) renderer PRs that build on top of this one. The XR_FB_space_warp OpenXR extension can then be utilized by building the OpenXR vendor repo with GodotVR/godot_openxr_vendors#222.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I already reviewed these changes as part of PR #97151 (before the changes were moved here) and, skimming through this PR, everything still looks good to me :-)

@devloglogan devloglogan requested a review from clayjohn December 12, 2024 16:54
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering API changes look great to me!

We already discussed them in the original PR, so I think this is safe to go ahead

@clayjohn clayjohn modified the milestones: 4.x, 4.4 Dec 12, 2024
@Repiteo Repiteo merged commit bfc66f0 into godotengine:master Dec 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants