Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EditorInterface.popup_create_dialog() as experimental #100731

Conversation

Lazy-Rabbit-2001
Copy link
Contributor

Should have done this, but I forgot that...
Thanks godotengine/godot-proposals#11238 (comment) for informing.

@Lazy-Rabbit-2001 Lazy-Rabbit-2001 requested a review from a team as a code owner December 22, 2024 07:55
@Chaosus Chaosus added this to the 4.4 milestone Dec 22, 2024
@AThousandShips AThousandShips changed the title Tiny fix: Marked EditorInterface.popup_create_dialog() as experimental Mark EditorInterface.popup_create_dialog() as experimental Dec 22, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, we can easily remove if we change our mind on it

@Repiteo Repiteo merged commit b77fde8 into godotengine:master Dec 23, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 23, 2024

Thanks!

@Lazy-Rabbit-2001 Lazy-Rabbit-2001 deleted the popup_create_dialog_as_experimental branch December 24, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants