Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shifted joint radius index in SpringBone gizmo and remove unused end_bone_tip_radius property #101525

Merged

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jan 14, 2025

The joint drawing index was misaligned and will be corrected.

Before this fix, the root bone's radius was being treated as if it were invalid, when in fact it was valid.

Wrong gizmo:

-(1)-(2)-(3)-(end)

Wrong gizmo (extend end bone):

-(1)-(2)-(3)-(end)-(tip)

Internally, it behaved like this in the colliding process:

-(root)-(1)-(2)-(3)

Internally, it behaved like this in the colliding process (extend end bone):

-(root)-(1)-(2)-(3)-(end)

So this PR fix gizmo index to the latter.

The tip radius was only being used for drawing purposes, but was not actually working in colliding process. Since the end bone's radius is actually used and tip radius is not doing anything, remove it.

Also write end_bone behavior in detail in the documentation.

@TokageItLab TokageItLab changed the title Fix shifted the joint radius index in SpringBone gizmo and remove the property that was not actually working Fix shifted the joint radius index in SpringBone gizmo and remove the end_bone_tip_radius property that was not actually working Jan 14, 2025
@TokageItLab TokageItLab requested a review from akien-mga January 14, 2025 07:16
@TokageItLab TokageItLab force-pushed the fix-shifted-joint-spring-bone branch from 723aba2 to a55faaf Compare January 14, 2025 07:23
@TokageItLab TokageItLab force-pushed the fix-shifted-joint-spring-bone branch from a55faaf to 7b3d14f Compare January 14, 2025 07:28
@akien-mga akien-mga changed the title Fix shifted the joint radius index in SpringBone gizmo and remove the end_bone_tip_radius property that was not actually working Fix shifted joint radius index in SpringBone gizmo and remove unused end_bone_tip_radius property Jan 14, 2025
@akien-mga akien-mga merged commit dde7a94 into godotengine:master Jan 14, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants