Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify SpringBoneSimulator3D's gravity units and improve documentation #101652

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Clarify SpringBoneSimulator3D's gravity units and improve documentation #101652

merged 1 commit into from
Jan 17, 2025

Conversation

TokageItLab
Copy link
Member

Context is #101633 (comment). Clarify what it is about the gravity parameter.

@TokageItLab TokageItLab added this to the 4.4 milestone Jan 16, 2025
@TokageItLab TokageItLab requested a review from a team January 16, 2025 22:03
@TokageItLab TokageItLab requested review from a team as code owners January 16, 2025 22:03
@TokageItLab TokageItLab mentioned this pull request Jan 16, 2025
Open
fire
fire approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this pull request in 4.4 because it is a documentation change for an unreleased feature.

@Repiteo Repiteo merged commit 9875cb6 into godotengine:master Jan 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:animation topic:3d
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@TokageItLab @Repiteo @fire