Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing base class call in JoltArea3D::post_step #101727

Closed
wants to merge 1 commit into from

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Jan 18, 2025

Fixes #101695.

We need to call the non-empty base class implementation of JoltShapedObject3D::post_step from JoltArea3D::post_step, otherwise we never clear JoltShapedObject3D::previous_jolt_shape after modifying the Area3D shape(s), which causes the forced exit + enter events to be queued up in JoltContactListener3D::_flush_area_shifts every single physics step, as opposed to just once.

@mihe
Copy link
Contributor Author

mihe commented Jan 19, 2025

I'm realizing that #101695 is tangentially related to #101721, so I'll be putting up a new pull request that fixes both of them, where this JoltArea3D::post_step method will go away completely.

@mihe mihe closed this Jan 19, 2025
@mihe mihe deleted the jolt/missing-base-call branch January 19, 2025 20:34
@mihe mihe added the archived label Jan 19, 2025
@mihe mihe removed this from the 4.4 milestone Jan 19, 2025
@mihe
Copy link
Contributor Author

mihe commented Jan 19, 2025

The superseding PR can be found here: #101815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants