Tree - fix ui_select
#101842
Merged
Tree - fix ui_select
#101842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix works for default controls, but with custom input actions you can still run into the same problem, but reverse. Although not sure how it can be handled better. Maybe it's not worrying about. |
KoBeWi
approved these changes
Jan 20, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found in #101160
ui_acceptandui_selectare programmed so that they are mutually exclusive.The default assignments is:
ui_accept- Enter and Spaceui_select- SpaceI have decided to just change the order of these checks, because I think it would be confusing if both actions would be triggered and because
ui_acceptcan use a different key (Enter) instead.