Wayland: Pass unmodified symbols to key events #101848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we would internationalize the keycode itself in all `InputEventKey`s, confusing the whole input subsystem.
This was referenced Jan 20, 2025
bruvzg
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
I can reproduce the issue (as described in #100713 (comment)) and confirm it is fixed.
|
Thanks! |
|
@Riteo, For some reason this has broken the keypad for me when using Wayland on Fedora. It is always stuck in num-lock off mode event when it is on. |
|
@tdaven thank you for catching this! Yeah, I can replicate that. Taking a closer look at the X11 code, it seems that the backend only filters out control and shift, but not caps lock, alt, num lock or super. That's a bit confusing. I'll file a fixup PR ASAP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100713
Fixes #100879
Before this change we would internationalize the keycode itself in all
InputEventKeys, confusing the whole input subsystem.