Fix cpuparticles randomness regression #101872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
KoBeWi
reviewed
Jan 21, 2025
scene/2d/cpu_particles_2d.h
Outdated
| @@ -179,6 +180,8 @@ class CPUParticles2D : public Node2D { | |||
|
|
|||
| Vector2 gravity = Vector2(0, 980); | |||
|
|
|||
| Ref<RandomNumberGenerator> _rng; | |||
There was a problem hiding this comment.
Suggested change
| Ref<RandomNumberGenerator> _rng; | |
| Ref<RandomNumberGenerator> rng; |
We don't underscore private variables.
KoBeWi
reviewed
Jan 21, 2025
scene/2d/cpu_particles_2d.h
Outdated
| @@ -31,6 +31,7 @@ | |||
| #ifndef CPU_PARTICLES_2D_H | |||
| #define CPU_PARTICLES_2D_H | |||
|
|
|||
| #include "core/math/random_number_generator.h" | |||
There was a problem hiding this comment.
Use forward declaration instead of include.
KoBeWi
reviewed
Jan 21, 2025
scene/2d/cpu_particles_2d.cpp
Outdated
| Vector2 rot = Vector2(Math::cos(angle1_rad), Math::sin(angle1_rad)); | ||
| p.velocity = rot * Math::lerp(parameters_min[PARAM_INITIAL_LINEAR_VELOCITY], parameters_max[PARAM_INITIAL_LINEAR_VELOCITY], (real_t)rand_from_seed(_seed)); | ||
| p.velocity = rot * Math::lerp(parameters_min[PARAM_INITIAL_LINEAR_VELOCITY], parameters_max[PARAM_INITIAL_LINEAR_VELOCITY], (real_t)_rng->randf()); |
There was a problem hiding this comment.
Suggested change
| p.velocity = rot * Math::lerp(parameters_min[PARAM_INITIAL_LINEAR_VELOCITY], parameters_max[PARAM_INITIAL_LINEAR_VELOCITY], (real_t)_rng->randf()); | |
| p.velocity = rot * Math::lerp(parameters_min[PARAM_INITIAL_LINEAR_VELOCITY], parameters_max[PARAM_INITIAL_LINEAR_VELOCITY], _rng->randf()); |
randf() already returns real_t, so not sure what the cast was for.
KoBeWi
approved these changes
Jan 21, 2025
AThousandShips
changed the title
QbieShay
force-pushed
the
qbe/fix-particle-random
branch
from
b93216c to
c8b0509
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101859