Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] embree: Fix invalid output operators raising errors with GCC 15 #102023

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

akien-mga
Copy link
Member

I've confirmed this fixes this FTBFS on Fedora 42 with GCC: https://bugzilla.redhat.com/show_bug.cgi?id=2340257

This was fixed upstream by RenderKit/embree@cda4cf1.

We already backported that fix for Godot master in c24ea0e, though that needs to be cherry-picked for 4.0 - 4.2.

@akien-mga akien-mga added bug topic:buildsystem topic:thirdparty cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Jan 25, 2025
@akien-mga akien-mga added this to the 3.7 milestone Jan 25, 2025
@akien-mga akien-mga requested a review from a team as a code owner January 25, 2025 14:29
@akien-mga akien-mga changed the title embree: Fix invalid output operators raising errors with GCC 15 [3.x] embree: Fix invalid output operators raising errors with GCC 15 Jan 25, 2025
@akien-mga akien-mga merged commit 56d8204 into godotengine:3.x Jan 30, 2025
14 checks passed
@akien-mga akien-mga deleted the 3.x-embree-fix-gcc15 branch January 30, 2025 07:59
@akien-mga
Copy link
Member Author

akien-mga commented Jan 30, 2025

Cherry-picked for 3.6, 3.5, 3.4, and 3.3 branches.

@akien-mga akien-mga removed cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant