Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Remove unused code from godot_windows.cpp. #102134

Merged
merged 1 commit into from
Jan 29, 2025
Merged

[Windows] Remove unused code from godot_windows.cpp. #102134

merged 1 commit into from
Jan 29, 2025
+0 −84

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 28, 2025

This function was never used and can be confused with CommandLineToArgvW.

@bruvzg bruvzg added this to the 4.4 milestone Jan 28, 2025
@bruvzg bruvzg requested a review from a team as a code owner January 28, 2025 18:16
fire
fire approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github passed, and there were no integration test complaints.

@Repiteo Repiteo merged commit f4c2fff into godotengine:master Jan 29, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 29, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:windows topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @Repiteo @fire @akien-mga