Use iterator pattern instead of manually traverse List::Element *
#102354
+155
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YYF233333
force-pushed
the
style_iterator
branch
from
740f08a to
a669c2a
Compare
YYF233333
force-pushed
the
style_iterator
branch
from
a669c2a to
6601eb7
Compare
AThousandShips
changed the title
List::Element *List::Element *
adamscott
reviewed
Feb 3, 2025
core/core_bind.cpp
Outdated
| @@ -466,8 +466,8 @@ bool OS::is_restart_on_exit_set() const { | |||
| Vector<String> OS::get_restart_on_exit_arguments() const { | |||
| List<String> args = ::OS::get_singleton()->get_restart_on_exit_arguments(); | |||
| Vector<String> args_vector; | |||
| for (List<String>::Element *E = args.front(); E; E = E->next()) { | |||
| args_vector.push_back(E->get()); | |||
| for (const String &E : args) { | |||
There was a problem hiding this comment.
We shouldn't reuse the same variable name here. Before, E was short for List<String>::Element, but now, it means arg.
Suggested change
| for (const String &E : args) { | |
| for (const String &arg : args) { |
This comment is good for all the replacements in the PR.
There was a problem hiding this comment.
Or whatever is applicable in that context; if nothing feels appropriate, something generic like item or element works just as well
There was a problem hiding this comment.
Thanks for the naming suggestion. I'm not very familiar with these code, so I prefer to use the original names to avoid issues like name conflicts. If you have a better name in mind, please feel free to suggest it.
YYF233333
force-pushed
the
style_iterator
branch
from
b910fb8 to
306a3c4
Compare
Co-authored-by: Adam Scott <[email protected]>
YYF233333
force-pushed
the
style_iterator
branch
from
306a3c4 to
7b486a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a style change.
for (List<>::Element *E = list.front(); E; E = E->next())is lengthy and hard to read,for (const Type &E : list)make it clear that we are doing a one-way scan and not mutating the container or elements.An additional benefit is that we have removed the type name of
Listfrom the loop, making it possible to replace the container type in the future. In the previous pattern, we would have to modify theforloop if we wanted to replaceListwithVectororLocalVector.