Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let SceneTreeDock duplicate nodes via Node::duplicate() #13041

Merged
merged 2 commits into from
Nov 20, 2017

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Nov 19, 2017

A small logic fix is included as a separate commit, since that should be done regardless the code was to be unified or not.

This is implemented on top of #13040, so it should be merged after it. That one already merged. This one rebased against current _master-.

Helps with #11182.

@reduz
Copy link
Member

reduz commented Nov 19, 2017 via email

@RandomShaper
Copy link
Member Author

The only thing thas SceneTreeDock::duplicate() had in relation to undo/redo was the "duplimap" and it is now collected at Node::_duplicate() when running in the special editor mode (called through Node::duplicate_from_editor()).

@RandomShaper
Copy link
Member Author

I've done my best to transfer to Node::_duplicate() all the logic differences present in SceneTreeDock::_duplicate() with special tools-only flags.

@akien-mga akien-mga merged commit 49a7318 into godotengine:master Nov 20, 2017
@RandomShaper RandomShaper deleted the unify-node-duplicate branch November 20, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants