Rename collision_friction to friction in TileMap #18191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't be changed like this, it'll break compatibility with existing projects. |
|
Fair point. Will adjust accordingly. |
Renames the collision_friction property to friction in the TileMap class to conform with the naming in other classes. The documentation is updated accordingly. The previous property accessor, getter and setter have been retained for compatibility. Fixes #18190
83 tasks
|
Thanks for the proposal, that's a good change, but indeed compatibility is an issue. The way you added it by keeping the deprecated methods bound is good, but it makes it hard to keep track of what is deprecated. It would require #4397 to be implemented to be done properly, so for now I've added it to the list in #16863. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the collision_friction property to friction in the TileMap class
to conform with the naming in other classes.
The documentation is updated accordingly.
Fixes #18190