Improve Visual Shader Editor responsiveness

[MarianoGnu]

According to 1.2 plan i'm working in the next points:

• Shader new node placement
• Multiple GraphNode selection and move
• Box selection
• Delete key removes nodes
• Shader nodes duplicate
• Default shader nodes values
• Zoom for Visual Shader Editor

[reduz]

About to take the plane back to buenos aires, will check when I arrive
On Jul 17, 2015 3:47 AM, "Mariano Javier Suligoy" [email protected]
wrote:

According to 1.2 plan i'm working in the next points:

• Shader new node placement
• Shader nodes copy-paste / duplicate
• Default shader nodes values
• Zoom for Visual Shader Editor

---

You can view, comment on, or merge this pull request online at:

#2274
Commit Summary

• Use popup menu to add new nodes to the shader graph editor in the
  last clicked location.

File Changes

• M scene/gui/graph_edit.cpp
  https://github.com/okamstudio/godot/pull/2274/files#diff-0 (14)
• M tools/editor/plugins/shader_graph_editor_plugin.cpp
  https://github.com/okamstudio/godot/pull/2274/files#diff-1 (37)
• M tools/editor/plugins/shader_graph_editor_plugin.h
  https://github.com/okamstudio/godot/pull/2274/files#diff-2 (6)

Patch Links:

• https://github.com/okamstudio/godot/pull/2274.patch
• https://github.com/okamstudio/godot/pull/2274.diff

—
Reply to this email directly or view it on GitHub
#2274.

[MarianoGnu]

Box selection added.

Hold Control to make an additive selection without losing previous node selection:

Hold Shift to deselect nodes inside the rectangle:

Press right mouse button while using the tool to cancel the selection.

[mamarilmanson]

I wonder why you went to Ctrl as additive and Shift as Subtractive? :)

[MarianoGnu]

Control is default for aditive selections on file browsers, maybe alt should be fine for substractive, i just felt this was enought straightforward (people usually learn these stuff just trying out)

[mamarilmanson]

Oh ok... here's what's really happening in other software/file browser...

SHIFT is for selecting multiple objects at the same time...
CTRL is for selecting multiple objects one at a time...
ALT is for Subtractive...

hope this info helps... :)

[reduz]

check how godot does it and do the same, honestly this is different in
every software

On Sat, Jul 25, 2015 at 10:11 PM, Manson Mamaril [email protected]
wrote:

Oh ok... here's what's really happening in other software/file browser...

SHIFT is for selecting multiple objects at the same time...
CTRL is for selecting multiple objects one at a time...
ALT is for Subtractive...

hope this info helps... :)

—
Reply to this email directly or view it on GitHub
#2274 (comment).

[zhagsenkk]

why not allow users to set shortcuts themselves?

[mamarilmanson]

That's the best idea... 👍 for that... I don't know how to code godot... so all I can give are ideas, suggestion and moral support...

@MarianoGnu ~ Please do implement custom shortcuts... :)

[reduz]

no custom shortcuts for now

On Sun, Jul 26, 2015 at 4:06 AM, Manson Mamaril [email protected]
wrote:

That's the best idea... [image: 👍] for that... I don't know how to
code godot... so all I can give are ideas, suggestion and moral support...

@MarianoGnu https://github.com/MarianoGnu ~ Please do implement custom
shortcuts... :)

—
Reply to this email directly or view it on GitHub
#2274 (comment).

[MarianoGnu]

A little addition to PR roadmap: Delete key remove selected nodes (except for Output of course)

[MarianoGnu]

I give up into implementing UI zoom... @reduz , @okamstudio you can merge this alredy if you want

[reduz]

no worries, i can try implementing this

On Sun, Aug 30, 2015 at 7:41 PM, Mariano Javier Suligoy <
[email protected]> wrote:

I give up into implementing UI zoom... @reduz https://github.com/reduz
, @okamstudio https://github.com/okamstudio you can merge this alredy
if you want

—
Reply to this email directly or view it on GitHub
#2274 (comment).

[MarianoGnu]

@reduz this is finally fixed and ready to merge