Improve the project manager UI #31356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before and after pics are identical? 😕 |
Search bar changed. That's the only visual change that I noticed from the pictures do far. |
Counted 8 differences so far, look more :) |
akien-mga
reviewed
Aug 13, 2019
|
Glad the mockup could be of some help! @Calinou 😁 |
|
I like the 'Search' faded text in the search box, very nice. For the sort dropdown, could possibly add more options.
Just throwing it out there. |
|
@mindinsomnia That could be done in a later pull request 🙂 |
Calinou
force-pushed
the
improve-project-manager-ui
branch
from
0cc4d67 to
e12759c
Compare
|
Very nice improvements overall! Now that I think about it, should the search bar be centered? |
|
Seems good to me, needs a rebase and it can be merged. |
This incorporates many suggestions from godotengine#31342. This also revises the search behavior to be simpler and more efficient: - Searching will now search in both the project name and path. A project will be displayed if either of these match the search term. - If the search term contains a "/", the whole path will be used to match the search term. Otherwise, only the last path component will be used.
Calinou
force-pushed
the
improve-project-manager-ui
branch
from
e12759c to
cef7ca4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates many suggestions from #31342.
This also revises the search behavior to be simpler and more efficient:
Props to @mindinsomnia for providing an high-quality mockup on #31342! ❤️
Preview
Before
After