Remove translation change notification when setting the locale of a Translation resource #34587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spend a hour trying to find the source of a bug in my code as to why
NOTIFICATION_TRANSLATION_CHANGED
was being triggered when I was not changing the game's locale. The cause? Apparently loading aTranslation
resource via code triggers theset_locale()
method in it, triggering the notification.While I get it why it triggers it when changing the locale of the whole game (via
TranslationServer
), triggering the notification by changing the locale of a resource doesn't make much sense to me.