Reset origin of dragged scene preview #36309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groud
reviewed
Feb 17, 2020
|
|
||
| Node2D *n = Object::cast_to<Node2D>(instance); | ||
| if (n) { | ||
| n->set_position(Vector2()); |
There was a problem hiding this comment.
Does not _edit_set_position() work for both ?
There was a problem hiding this comment.
It doesn't work for Control when anchor-only mode is enabled.
|
As mentioned in #26549, I think we should not reset the origin of a dragged scene. The bug in #26549 IMO is that the Sprite's position is reset to the cursor drop position, instead of keeping its transform as in the original scene. If you drag a scene with its "content" at an offset of So it's not the preview which should be reset, it's the actual drag application which is wrong and loses the transform. |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jun 22, 2020
|
Superseded by #39754. |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jun 29, 2020
Fixes godotengine#26549. Supersedes godotengine#36309. (cherry picked from commit a403131)
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
Fixes godotengine#26549. Supersedes godotengine#36309. (cherry picked from commit a403131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes half of #26549
Before:
Now:
I have no idea how to snap this to grid though.