Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize pointer in Object constructor #38681

Closed
wants to merge 1 commit into from

Conversation

hbina
Copy link
Contributor

@hbina hbina commented May 11, 2020

Pretty sure this will break formatting guideline. But I don't have access to the actual project right now.
I have force pushed the correct styling.

@hbina hbina force-pushed the patch-2 branch 2 times, most recently from 953c5d4 to da0b9d9 Compare May 12, 2020 02:00
@Calinou Calinou added this to the 4.0 milestone May 12, 2020
core/object.h Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Uninitialized pointer. Initialize pointer in Object constructor May 12, 2020
Also used initializer list (? I think this is the correct terminology).
@hbina
Copy link
Contributor Author

hbina commented May 14, 2020

I guess #38697 will supersede this change?

@akien-mga
Copy link
Member

I guess #38697 will supersede this change?

As a matter of fact I had missed that one so up to now it didn't, but I'm now including these changes in #38697 to change all at once (and avoid an extra full rebuild of the engine due to a object.h change).

Thanks for finding this one in any case :)

@akien-mga akien-mga closed this May 14, 2020
@hbina hbina deleted the patch-2 branch May 18, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants