Backport translator comment PR to 3.2 #41859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 7, 2020
| @@ -100,7 +220,7 @@ def process_file(f, fname): | |||
| print("Updating the editor.pot template...") | |||
|
|
|||
| for fname in matches: | |||
| with open(fname, "r") as f: | |||
| with open(fname, "r", encoding="utf8") as f: | |||
There was a problem hiding this comment.
This will break Python 2 compatibility, you should use open_utf8 from our compat.py (import compat).
There was a problem hiding this comment.
Ah nevermind, this is not part of the buildsystem so it doesn't matter.
But might be worth bumping the shebang to python3 then.
There was a problem hiding this comment.
Ahh ok. Didn't see your msg. I will revert the changes.
There was a problem hiding this comment.
@akien-mga You want me to change to #!/usr/bin/env python3? I didn't understand the shebang part until now.
The /usr/bin/env part I refer from this discussion.
akien-mga
approved these changes
Sep 7, 2020
SkyLucilfer
force-pushed
the
TranslatorComment32
branch
from
5f35f42 to
4364b17
Compare
SkyLucilfer
force-pushed
the
TranslatorComment32
branch
from
4364b17 to
1ba5917
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #41510 to 3.2 branch.