Rename the type parameter to node_type in Theme and Control
#42008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
theme-rename-node-type
branch
from
734bf9c to
42a6fdc
Compare
Calinou
changed the title
type parameter to node_type in the Theme classtype parameter to node_type in Theme and Control
Calinou
force-pushed
the
theme-rename-node-type
branch
from
42a6fdc to
568b35d
Compare
|
Please note that in case of |
|
Needs a rebase. |
This makes it clearer that it expects a node type as a string (such as "Label") instead of a type like "TYPE_ARRAY". This is backwards-compatible since only the name of the parameter is changed, not its order.
Calinou
force-pushed
the
theme-rename-node-type
branch
from
568b35d to
c3b246e
Compare
akien-mga
approved these changes
Nov 16, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer that it expects a node type as a string (such as "Label") instead of a type like "TYPE_ARRAY". This is backwards-compatible since only the name of the parameter is changed, not its order.
3.2 version in #42009.
See godotengine/godot-proposals#1495 (comment).