Add a test suite for OS #42069
Merged
Add a test suite for OS #42069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Sep 15, 2020
Calinou
force-pushed
the
test-add-os
branch
from
7d96c4a to
ab97b30
Compare
Calinou
force-pushed
the
test-add-os
branch
from
ab97b30 to
17c276c
Compare
|
Needs a rebase. The test seems to fail on Linux (at least on the CI). |
|
The PR has conflicts with |
99 tasks
Merged
|
Needs rebase and fixing CI, otherwise would be good to merge. |
Calinou
force-pushed
the
test-add-os
branch
3 times, most recently
from
9454ee9 to
322a724
Compare
|
This passes CI now, so it should be ready to merge 🙂 |
akien-mga
approved these changes
Jul 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to test this class well, as some of these tests might be a bit flaky or not very useful. They still all pass on my machine.