Add a test suite for Rect2 and Rect2i #43514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
aaronfranke
reviewed
Nov 14, 2020
Calinou
force-pushed
the
test-add-rect2-rect2i
branch
from
2ecd88c to
ad2d988
Compare
|
I added tests for |
|
Style issue after recent change to file_format.sh. |
Calinou
force-pushed
the
test-add-rect2-rect2i
branch
from
ad2d988 to
7cb21c2
Compare
akien-mga
approved these changes
Nov 20, 2020
|
Thanks! |
aaronfranke
reviewed
May 20, 2021
Comment on lines
+323
to
+328
| CHECK_MESSAGE( | ||
| Math::is_equal_approx(Rect2i(0, 100, -1280, 720).get_area(), -921'600), | ||
| "get_area() should return the expected value."); | ||
| CHECK_MESSAGE( | ||
| Math::is_zero_approx(Rect2i(0, 100, 0, 720).get_area()), | ||
| "get_area() should return the expected value."); |
There was a problem hiding this comment.
Heads up for the future: You don't need to use is_equal_approx and is_zero_approx to compare integers :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.