Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Vector2.tangent() to Vector2.orthogonal() #44149

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

madmiraal
Copy link
Contributor

As identified by @razcore-art:

Vector2.tangent() is described in the docs as: Returns a perpendicular vector., that's the definition of orthogonal or orthonormal if the returned vector is normalized. Since Vector2.tangent() returns a non-normalized vector I propose we should rename it to Vector2.orthogonal()...

Part of #16863.

@aaronfranke
Copy link
Member

Mutually incompatible with #39685. If one of these is merged, the other should be closed.

@akien-mga akien-mga merged commit 058f3fe into godotengine:master Dec 28, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants